Skip to content

[Test] Tolerate intermittent dcvsessionlauncher crash on g5g instances.#7350

Merged
gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3160/test-dcv-0422-3
May 13, 2026
Merged

[Test] Tolerate intermittent dcvsessionlauncher crash on g5g instances.#7350
gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3160/test-dcv-0422-3

Conversation

@gmarciani
Copy link
Copy Markdown
Contributor

@gmarciani gmarciani commented Apr 22, 2026

Description of changes

Tolerate the known dcvsessionlauncher SEGV (g_subprocess_send_signal -> on_read_startup_string_ready) on g5g instances.

This crash is caused by a DCV bug they are actively investigating. The crash is intermittent and even when it occurs its impact is intermittent and only on the first dcv connection. There is no point for us to alarm on this specific crash because, when it is impactful, the test will detect the failure in the dcv connection.

Tests

SUCCESS test_dcv_configuration

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Apr 22, 2026
@gmarciani gmarciani force-pushed the wip/mgiacomo/3160/test-dcv-0422-3 branch from 7b6a534 to df9a730 Compare April 22, 2026 23:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (a1e1583) to head (df9a730).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7350      +/-   ##
===========================================
- Coverage    90.08%   90.07%   -0.01%     
===========================================
  Files          182      182              
  Lines        16730    16732       +2     
===========================================
+ Hits         15071    15072       +1     
- Misses        1659     1660       +1     
Flag Coverage Δ
unittests 90.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmarciani gmarciani force-pushed the wip/mgiacomo/3160/test-dcv-0422-3 branch 4 times, most recently from 87bb84c to 9abc145 Compare May 1, 2026 19:13
@gmarciani gmarciani marked this pull request as ready for review May 7, 2026 15:20
@gmarciani gmarciani requested review from a team as code owners May 7, 2026 15:20
himani2411
himani2411 previously approved these changes May 7, 2026
Copy link
Copy Markdown
Contributor

@himani2411 himani2411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tolerate the known dcvsessionlauncher SEGV (g_subprocess_send_signal -> on_read_startup_string_ready) on g5g instances.

This crash has an intermittent impact only on the creation of the first dcv session.
When it is impactful, the check on dcv connectivity already fails.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3160/test-dcv-0422-3 branch from c451882 to 0efc1e9 Compare May 8, 2026 15:01
@gmarciani gmarciani enabled auto-merge (rebase) May 13, 2026 07:30
@gmarciani gmarciani merged commit 5e75802 into aws:develop May 13, 2026
24 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3160/test-dcv-0422-3 branch May 13, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants