Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,13 @@
* <p>See software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient for an alternative implementation.</p>
*
* <p>This can be created via {@link #builder()}</p>
*
* @deprecated Apache 4.x is in maintenance mode. Users are encouraged to switch to the
* <a href="https://docs.aws.amazon.com/java/api/latest/software/amazon/awssdk/http/apache5/Apache5HttpClient.html">Apache 5 HTTP Client</a>
* which is feature compatible with this client.
*/
@SdkPublicApi
@Deprecated
public final class ApacheHttpClient implements SdkHttpClient {

public static final String CLIENT_NAME = "Apache";
Expand Down Expand Up @@ -345,6 +350,9 @@ public String clientName() {
* .socketTimeout(Duration.ofSeconds(10))
* .build();
* </pre>
* @deprecated Apache 4.x is in maintenance mode. Users are encouraged to switch to the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we need this same exact comment duplicated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* <a href="https://docs.aws.amazon.com/java/api/latest/software/amazon/awssdk/http/apache5/Apache5HttpClient.html">Apache 5 HTTP Client</a>
* which is feature compatible with this client.
*/
public interface Builder extends SdkHttpClient.Builder<ApacheHttpClient.Builder> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,13 @@

/**
* Service binding for the Apache implementation.
*
* @deprecated Apache 4.x is in maintenance mode. Users are encouraged to switch to the
* <a href="https://docs.aws.amazon.com/java/api/latest/software/amazon/awssdk/http/apache5/Apache5HttpClient.html">Apache 5 HTTP Client</a>
* which is feature compatible with this client.
*/
@SdkPublicApi
Comment thread
dagnir marked this conversation as resolved.
@Deprecated
public class ApacheSdkHttpService implements SdkHttpService {
@Override
public SdkHttpClient.Builder createHttpClientBuilder() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,13 @@

/**
* Configuration that defines how to communicate via an HTTP or HTTPS proxy.
*
* @deprecated Apache 4.x is in maintenance mode. Users are encouraged to switch to the
* <a href="https://docs.aws.amazon.com/java/api/latest/software/amazon/awssdk/http/apache5/Apache5HttpClient.html">Apache 5 HTTP Client</a>
* which is feature compatible with this client.
*/
@SdkPublicApi
@Deprecated
public final class ProxyConfiguration implements ToCopyableBuilder<ProxyConfiguration.Builder, ProxyConfiguration> {
private final URI endpoint;
private final String username;
Expand Down
Loading