Skip to content

rename: framework huggingface-pytorch -> huggingface-pytorch-training - #6492

Merged
qinzhounick merged 2 commits into
mainfrom
hf/hf-pytorch-training-rename-framework
Aug 5, 2026
Merged

rename: framework huggingface-pytorch -> huggingface-pytorch-training#6492
qinzhounick merged 2 commits into
mainfrom
hf/hf-pytorch-training-rename-framework

Conversation

@dwarez

@dwarez dwarez commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Rename metadata.framework from huggingface-pytorch to huggingface-pytorch-training, per review feedback on #6476. The old name is ambiguous once a huggingface-pytorch-inference family exists.

metadata.framework is a derivation key, not just a label, so four other places follow:

  • test/security/data/ecr_scan_allowlist/huggingface-pytorch/huggingface-pytorch-training/ecr_scan.py resolves <dir>/<framework>/framework_allowlist.json. Without the directory rename the CVE-2026-24747 entry stops applying and the scan fails.
  • huggingface-pytorch-training.pr-2.11.yml (2 lines) — path filters for that directory.
  • deep_learning_container.py--framework choices, otherwise telemetry fails in-container with invalid choice.
  • docker/huggingface/pytorch/DockerfileARG FRAMEWORK default, for local builds without --build-arg.

Also matches docs/src/global.yml and docs/src/data/huggingface-pytorch-training/, which already use the new name.

Second commit is not part of the rename, but clears this image's ECR scan: cryptography>=50.0.0 (CVE-2026-69247, CVE-2026-69249) and aiohttp>=3.14.3 (CVE-2026-69244), added to the existing security-floor block in docker/huggingface/pytorch/Dockerfile.

PR Checklist

  • I ran pre-commit run --all-files locally before creating this PR. (Read DEVELOPMENT.md for details).

Signed-off-by: DWarez <dario.salvati@huggingface.co>
Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez
dwarez requested a review from qinzhounick August 5, 2026 17:16
@qinzhounick
qinzhounick merged commit 481494a into main Aug 5, 2026
564 of 566 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants