rename: framework huggingface-pytorch -> huggingface-pytorch-training - #6492
Merged
Conversation
Signed-off-by: DWarez <dario.salvati@huggingface.co>
Signed-off-by: DWarez <dario.salvati@huggingface.co>
qinzhounick
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rename
metadata.frameworkfromhuggingface-pytorchtohuggingface-pytorch-training, per review feedback on #6476. The old name is ambiguous once ahuggingface-pytorch-inferencefamily exists.metadata.frameworkis a derivation key, not just a label, so four other places follow:test/security/data/ecr_scan_allowlist/huggingface-pytorch/→huggingface-pytorch-training/—ecr_scan.pyresolves<dir>/<framework>/framework_allowlist.json. Without the directory rename the CVE-2026-24747 entry stops applying and the scan fails.huggingface-pytorch-training.pr-2.11.yml(2 lines) — path filters for that directory.deep_learning_container.py—--frameworkchoices, otherwise telemetry fails in-container withinvalid choice.docker/huggingface/pytorch/Dockerfile—ARG FRAMEWORKdefault, for local builds without--build-arg.Also matches
docs/src/global.ymlanddocs/src/data/huggingface-pytorch-training/, which already use the new name.Second commit is not part of the rename, but clears this image's ECR scan:
cryptography>=50.0.0(CVE-2026-69247, CVE-2026-69249) andaiohttp>=3.14.3(CVE-2026-69244), added to the existing security-floor block indocker/huggingface/pytorch/Dockerfile.PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).