feat(base): add telemetry to base images and enable telemetry tests - #6499
Open
sallyseok wants to merge 2 commits into
Open
feat(base): add telemetry to base images and enable telemetry tests#6499sallyseok wants to merge 2 commits into
sallyseok wants to merge 2 commits into
Conversation
Add DLC telemetry to the cu129/cu130/cu132 base Dockerfiles (runtime and devel stages) following the vllm pattern: copy deep_learning_container.py and render bash_telemetry.sh from the template via FRAMEWORK / FRAMEWORK_VERSION / CONTAINER_TYPE build-args, then source it from the bashrc files and set DLC_CONTAINER_TYPE. - Add botocore and packaging deps (required by the telemetry script for EC2 tagging and version validation) to all three base pyproject.toml files and regenerate the uv.lock files. - Wire the framework-agnostic telemetry test into base.pipeline.yml as a release-gated job, with run-telemetry-test inputs, path filters, and build-change triggers across the three base PR callers. - Rename framework "base_dlc" -> "base" across configs, sanity-test conditions, PR path filters, and the security allowlist dir/file. The telemetry script's argparse only accepts "base", so this is what makes --framework base valid for the shared test. docs(base): minor wording tweaks to match the public gallery docs. Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The base DLC images (cu129/cu130/cu132) were the only images missing DLC telemetry, and the framework-agnostic telemetry test (
test/telemetry/test_telemetry.py) was not wired into the base pipeline. This PR adds telemetry to the base Dockerfiles and enables the shared telemetry test for them.Changes:
runtimeanddevelstages of all three base Dockerfiles, following thedocker/vllm/Dockerfile.amzn2023pattern: copydeep_learning_container.py, renderbash_telemetry.shfrom the template viaFRAMEWORK/FRAMEWORK_VERSION/CONTAINER_TYPEbuild-args, source it from/etc/bashrc+/root/.bashrc, and setDLC_CONTAINER_TYPE.botocore(EC2 tagging) andpackaging(version validation), neither of which was present in the base images. Added both to all threepyproject.tomlfiles and regenerated theuv.locks.telemetry-testjob tobase.pipeline.yml, plusrun-telemetry-testinputs,telemetry-test-changepath filters, andbuild-changetriggers across the three base PR callers. Autorelease inherits the pipeline default (true).base_dlc→base— the base config was the only one usingframework: "base_dlc", but the telemetry script's argparse only ever accepted"base". Renamed across configs, sanity-test conditions, PR path filters, and the security allowlist dir/file. This is what makes--framework basevalid for the shared test, and the change is fully self-contained (nothing external derives frommetadata.frameworkfor base images).docs/base/index.mdto keep the docs site consistent with the public ECR gallery docs.Test Plan
pre-commit run --all-fileson the changed files (passes).bash_telemetry.shrenders from the template with no leftover{{...}}markers forFRAMEWORK=base.baseand rejectsbase_dlc.telemetry-testjob (build → telemetry-environment + telemetry-instance) will exercise the image end-to-end in CI.Test Result
Pending CI on this PR.
Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR.