fix(currency): make all ECR scan failures block merge conditions - #6500
Merged
Conversation
Per team decision, ECR vulnerability scans should gate merge for every framework, not just vLLM/SGLang Ubuntu. Remove the ecr-vulnerability-scan ignore pattern so any non-allowlisted CRITICAL/HIGH CVE blocks merge.
sallyseok
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
/ecr-vulnerability-scan$/entry fromignoredPatternsin Merge Conditions, so any ECR vulnerability scan failure (non-allowlisted CRITICAL/HIGH CVE) blocks merge for every framework.Why
Commit
66c2d54ahad made all ECR scans non-blocking. Per team discussion, we now want scan failures to gate merge across the board — not just for vLLM/SGLang Ubuntu.Effect on the Currency Fix Agent
The Currency Fix Agent (
_prcheck.currency-fix.yml) triggers when Merge Conditions concludesfailure. With scans blocking again, CVE failures on tracked auto-update PRs (vLLM/SGLang Ubuntu) will once more trigger the agent. Scans on other frameworks now also block merge for regular PRs.Relationship to #6494
This supersedes the partial vLLM/SGLang-Ubuntu-only blocking approach in #6494. If this PR is the agreed direction, the merge-conditions change in #6494 should be dropped (its Currency Fix Agent stale-commit + stop-label guard is still worth keeping — those changes are independent).
Testing