Metric update#735
Open
rakshil14-2 wants to merge 2 commits into
Open
Conversation
Update submodule added function to track features lint making public module fix CI errors Added TLS feature at CRT layer lint making aws_iot_metric public updating doc fix docs error Introduce Opt-out for Metrics updating doc_string updating submodules Test cases changing public attributes to private changed to public attributes
rakshil14-2
force-pushed
the
metric_update
branch
from
ed2b3c8 to
0356f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes:
AWSIoTMetricsclass as public. This class will hold all information regarding metrics.enableMetrics->disableMetrics: change name convention to disable to focus on the "opt-out" pattern.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.