feat(status): label transition_seconds with the destination status - #216
Merged
Conversation
The transition_seconds histogram only labeled the status a condition was LEFT (`status`), never the status it moved TO. A dwell in e.g. Ready=Unknown or Ready=False was therefore indistinguishable between "recovered to True" and any other outcome, so recovery-duration for a condition could not be isolated. Add a `to_status` label to `operator[_<kind>]_status_condition_transition_seconds`. `status` still means the state being left (backward compatible); `to_status` is the state entered. Recovery duration is then transition_seconds filtered to status=False/Unknown, to_status=True. The recovery *rate* can be derived by comparing that against transitions_total entries into the unhealthy state. Adds a test asserting the destination label is recorded on a transition.
DerekFrank
enabled auto-merge (squash)
August 12, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The transition_seconds histogram only labeled the status a condition was LEFT (
status), never the status it moved TO. A dwell in e.g. Ready=Unknown or Ready=False was therefore indistinguishable between "recovered to True" and any other outcome, so recovery-duration for a condition could not be isolated.Add a
to_statuslabel tooperator[_<kind>]_status_condition_transition_seconds.statusstill means the state being left (backward compatible);to_statusis the state entered. Recovery duration is then transition_seconds filtered to status=False/Unknown, to_status=True. The recovery rate can be derived by comparing that against transitions_total entries into the unhealthy state.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.