fix(admin): stop dark mode leaving light rows behind - #212
Conversation
Three admin screens still painted rows light under dark mode, and since the text is light there they were unreadable. myCRED paints both stripe parities itself (odd #fff, even #f6f7f7), and we only overrode the odd one, so every second row of the points history stayed white. The dashboard Activity widget does the same for the odd "Recently Published" rows and for every comment row, plus it pins the block headings to #1d2327 from an id selector, which our plain `h3` rule can't beat. The Recruit a Friend table is a Bootstrap one that leaves its cells transparent and keeps its own light text colour, so it depends on whatever is painted underneath. All three now get their background and text set explicitly in theme.css.
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Three admin screens still had light rows in dark mode, and since the text on them is light they were basically unreadable.
Chromie Points History (
users.php?page=mycred_default-history): myCRED paints both stripe parities itself (odd #fff,even #f6f7f7) and we only overrode the odd one, so every second row stayed white.Dashboard → Activity: WP paints the odd "Recently Published" rows and every comment row
#f6f7f7. It also pins the block headings ("Recently Published", "Recent Comments") to#1d2327from#dashboard-widgets h3, which our plainh3rule can't outweigh, so those headings were dark on dark.Recruit a Friend: the recruited-friends table is a Bootstrap one that leaves its cells transparent and keeps its own light text colour, so it takes whatever is painted underneath. Pinned both explicitly instead.
All of it lives in
theme.cssand is scoped underbody.acore-dark-mode, so light mode is untouched. Bumped the stylesheet version so browsers pick it up.Checked on a local wp-admin with dark mode on. Before and after, Activity widget and points history: