Skip to content

Duplicated parsing in tdf_reader.py #190

Description

@b-long

Some duplicated parsing was introduced by #188 .

is_tdf reimplements the same payload.get("url") extraction that payload_url_from_manifest_json already provides — it could just call that helper directly.

Note: Manifest.from_json is not a duplicate of that: it does full structural validation (raises on missing encryptionInformation, policy, segments, etc.), which is a different job than the lightweight "just peek at payload.url" probe.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions