fix(hook): forward approve feedback to Claude Code agent via systemMessage - #1440
Open
mangxy wants to merge 1 commit into
Open
fix(hook): forward approve feedback to Claude Code agent via systemMessage#1440mangxy wants to merge 1 commit into
mangxy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1359
On the Claude Code approve path, annotations collected in the review UI are silently dropped — only the
allowdecision (withupdatedInput/updatedPermissions) reaches the agent. The Gemini CLI approve path already forwards feedback viasystemMessage; the Claude Code path does not, so "annotate + approve" is indistinguishable from a plain approve.Change
One line in
apps/hook/server/index.ts: attach the collected feedback ashookSpecificOutput.systemMessageon the approve branch, mirroring the Gemini CLI path (line 2308).JSON.stringifydrops the field entirely when there is no feedback, so plain approves produce byte-identical output to before.Verification
main(9f9ee27) before patching.decision.message).