Skip to content

docs(skills): require gate for file approval - #1453

Merged
backnotprop merged 1 commit into
backnotprop:mainfrom
zhangjinzan1:fix/annotate-approval-gate-guidance
Sep 2, 2026
Merged

docs(skills): require gate for file approval#1453
backnotprop merged 1 commit into
backnotprop:mainfrom
zhangjinzan1:fix/annotate-approval-gate-guidance

Conversation

@zhangjinzan1

Copy link
Copy Markdown
Contributor

Summary

  • distinguish ordinary annotation from explicit file approval in the core skills
  • require --gate --json when a user asks to approve a saved plan/spec/document
  • clarify that --json alone does not enable the Approve button
  • add a regression assertion for the approval-gate guidance

Why

A Codex agent followed the installed core skill and launched a generated plan with plannotator annotate <file> --markdown --json. The UI correctly opened in plain annotate mode, so it showed Close but no Approve, even though the agent told the user they could approve the plan.

Test

  • bun test apps/hook/server/plannotator-skill-reference.test.ts (6 passed, 0 failed)
  • git diff --check

@backnotprop
backnotprop merged commit 85c4fa6 into backnotprop:main Sep 2, 2026
24 checks passed
@backnotprop

Copy link
Copy Markdown
Owner

Merged. Good catch on the gate/json distinction, and thanks for wiring the guidance into the freshness test so it cannot drift. This will ride the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants