Meap chap 1 5#1
Merged
Merged
Conversation
…and compatibility - Updated `quickstart.py` to enhance dataset preparation logic and improve length filtering feedback. - Revised `README.md` in chapter 3 to clarify package requirements and installation instructions, removing references to `unsloth`. - Modified `ch03_data_quality_explore.py` and `ch03_data_quality_helpers.py` to replace `unsloth` with `transformers + PEFT + TRL` for model training. - Enhanced `rag_minimal.py` with stable token hashing to ensure consistent embeddings across runs. - Updated `README.md` in chapter 5 to reflect Python version requirement change from 3.10 to 3.12 and clarified QLoRA compatibility on Apple Silicon. - Adjusted dataset preparation script in chapter 5 to ensure consistent UTC timestamp handling. - Updated `pyproject.toml` to reflect new dependency versions and compatibility notes. - Added `ACCELERATORS.md` to provide detailed guidance on running the code across different hardware setups and clarify GPU requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Related issue
Which chapter or area does this touch
How to test
Checklist
pytest -qpasses fromcode/ruff check .passes fromcode/Additional context