feat: Phase 6 — documentation, PNG icons, and PWA polish#7
Merged
Conversation
Pre-tasks: - Install @vite-pwa/assets-generator; generate PNG icons (64, 192, 512, maskable-512, apple-touch-180, favicon.ico) from SVG source - Replace SVG icon references in vite.config.ts manifest and index.html with generated PNGs; add apple-touch-icon link - Add workflow_dispatch trigger to deploy.yml; enable GitHub Pages (repo made public per open-source requirement) - Lighthouse 11 PWA score: 100/100 (was 88 before PNG icons) Documentation (Phase 6 tasks): - README.md: full quick-start, project structure, deploy notes, links - CONTRIBUTING.md: code of conduct stub, PR guide, coding conventions - docs/adding-a-method.md: step-by-step guide with field reference table and worked example (spatio-temporal FH) - docs/stata-v14-notes.md: v14 compatibility for all 16 methods with fallback details and R alternatives Catalogue reference URLs (task 5): - Add DOI or stable URL to every reference entry across all 16 catalogue files where a URL could be confirmed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vite-pwa/assets-generator(replaces SVG placeholders); Lighthouse 11 PWA score rises from 88 → 100workflow_dispatchREADME.md,CONTRIBUTING.md,docs/adding-a-method.md,docs/stata-v14-notes.mdPre-tasks completed
vite.config.tsmanifest +index.htmlapple-touch-iconAcceptance criteria
docs/adding-a-method.mdcomplete with field reference table and worked exampledocs/stata-v14-notes.mdcovers all 16 methodsnpm run buildpassesnpm testpasses (430/430)npm run lintpassesmainafter this PR is mergedTest plan
docs/adding-a-method.md— can a non-developer follow the guide alone?docs/stata-v14-notes.md— are all 16 methods covered correctly?npm run build && npm teston the branchgit tag v1.0.0 && git push origin v1.0.0🤖 Generated with Claude Code