Add dynamic instance buffers for runtime entity spawning - #1
Merged
Conversation
Instance buffers were previously allocated to exactly the initial entity count, making it impossible to spawn or despawn entities at runtime without a panic in write_buffer. Changes: - Add `instance_capacity` field to `ModelEntry` to track allocated slots - Allocate buffers at `max(initial_count, 64).next_power_of_two()` on startup so common cases (1 Sponza instance) get 64 slots of free headroom - In `update()`, detect when entity count exceeds capacity and recreate the buffer at `count.next_power_of_two()` slots before writing - Add `State::world_mut()` so game code can call `world_mut().spawn(...)` to add entities; buffers update automatically on the next frame Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance buffers were previously allocated to exactly the initial entity count, making it impossible to spawn or despawn entities at runtime without a panic in write_buffer.
Changes:
instance_capacityfield toModelEntryto track allocated slotsmax(initial_count, 64).next_power_of_two()on startup so common cases (1 Sponza instance) get 64 slots of free headroomupdate(), detect when entity count exceeds capacity and recreate the buffer atcount.next_power_of_two()slots before writingState::world_mut()so game code can callworld_mut().spawn(...)to add entities; buffers update automatically on the next frame