Skip to content

fix(devnet): bootstrap local Nitro proof stack - #4774

Draft
0x00101010 wants to merge 1 commit into
mainfrom
fix/anvil-nitro-local-bootstrap
Draft

fix(devnet): bootstrap local Nitro proof stack#4774
0x00101010 wants to merge 1 commit into
mainfrom
fix/anvil-nitro-local-bootstrap

Conversation

@0x00101010

Copy link
Copy Markdown
Contributor
  • Run the Base image through its bundled base executable when computing the genesis output root.
  • Seed and validate the protocol upgrade schedule during contract deployment so already-active upgrades do not revert bootstrap.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@depot-code-access

depot-code-access Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ All benchmarks green — 14 within ±2% (deterministic instruction counts). View run

Benchmark details (14)
Benchmark Base (target) Head (this PR) Δ instructions
batch_queue/drain/drain_cached_span_batches 242,027 242,027 +0.0%
batch_transaction/encode_in_place/encode_in_place 4,199,759 4,199,759 +0.0%
batch_transaction/temporary_frame_buffers/temporary_frame_buffers 8,408,350 8,408,350 +0.0%
flashblock_decode/decode/brotli 3,296,484 3,296,484 +0.0%
flashblock_decode/decode/plain_json 2,280,194 2,280,194 +0.0%
flz/compress_len/real_contract_call 43,148 43,148 +0.0%
flz/compress_len/synthetic_0 38,205 38,205 +0.0%
flz/compress_len/synthetic_1 54,682 54,682 +0.0%
flz/compress_len/synthetic_2 147,976 147,976 +0.0%
flz/data_gas 43,059 43,059 +0.0%
flz/tx_estimated_size 43,056 43,056 +0.0%
frame_parse/decode/single_4kib 1,031 1,031 +0.0%
frame_parse/parse_frames/few_large 1,053,062 1,053,062 +0.0%
frame_parse/parse_frames/many_small 154,763 154,763 +0.0%

@github-actions

Copy link
Copy Markdown
Contributor

Review Summary

This PR modifies the devnet bootstrap script (etc/scripts/devnet/anvil-nitro-local.sh) to fix two issues:

  1. The genesis_output_root docker command now correctly invokes ./base reth instead of just reth.
  2. Protocol upgrade schedule is seeded during contract deployment (via deploy config) rather than post-deployment registerUpgrade() calls, preventing already-active upgrades from reverting bootstrap. The old seed_protocol_versions is replaced by validate_protocol_versions which confirms on-chain state matches expectations.

No issues found. The L1 timestamp wait loop has a proper 2-minute deadline to avoid infinite hangs, the jq schedule comparison uses consistent compact formatting on both sides, and the empty-schedule edge case is handled correctly via // 0 fallback.

@depot-code-access

Copy link
Copy Markdown

Base Std historical fork tests

Fork Result Passed Failed Skipped base/base base-anvil base-std
Beryl pass 616 0 13 7be8a7fc cecddfa5 4658f1b7
Cobalt pass 721 0 14 7be8a7fc fb00db40 e30b3421

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants