Merge dashboard/permissions fixes, dep pin alignment, and upstream sync into bv-develop#12
Merged
Merged
Conversation
…ross models, migrations, business, REST, schemas, hooks, celery tasks, tests
…NOT NULL crash - custom_dashboard.owner_id had no ON DELETE rule, so deleting a dashboard's owner raised a raw ForeignKeyViolation/500 instead of orphaning the (possibly shared) dashboard. Set ondelete='SET NULL'. - AuthorizationGroupSchema.group_permissions had no load_default, so full loads (e.g. group creation) with the key omitted hit a NOT NULL violation. Add load_default=0.
flask-cors, SQLAlchemy, alembic, cryptography, pyotp, bleach had drifted to slightly older patch versions than the parallel dependency-update work on the upstream PR branch.
Merging the 3 new upstream commits re-forked the alembic head (dashboard_owner_fk vs collab_doc_seeder_version) - add the merge migration to resolve it. Also document a disposable iris-test podman stack for running the test suite without touching real dev-stack data/volumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan