Pin the Go toolchain to 1.26.7 to clear three stdlib advisories - #65
Open
jeremy wants to merge 1 commit into
Open
Pin the Go toolchain to 1.26.7 to clear three stdlib advisories#65jeremy wants to merge 1 commit into
jeremy wants to merge 1 commit into
Conversation
Govulncheck started failing on every open PR today: GO-2026-6090 (crypto/tls), GO-2026-6089 (net/http) and GO-2026-5972 (encoding/asn1), all reachable, all fixed in go1.26.6. Nothing in the source changed. go.mod carried a bare 'go 1.26', which setup-go resolves as >=1.26.0 <1.27 and satisfies from the runner's tool cache -- go1.26.5. Once the advisories landed, that cached patch was vulnerable and every build inherited it. Patch-pinning the go directive makes setup-go install an exact version, and covers all eight setup-go steps at once since they all read go-version-file: go.mod. It also matches kamal-proxy, once and basecamp-installer, which already patch-pin and carry no toolchain directive. Verified against the same tree: 3 vulns under go1.26.5, none under 1.26.6 or 1.26.7. build, vet, gofmt and the test suite pass on 1.26.7.
There was a problem hiding this comment.
Pull request overview
Pins the repository’s Go toolchain to 1.26.7, ensuring CI avoids vulnerable cached patch releases.
Changes:
- Updates the
godirective from 1.26 to 1.26.7.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Govulncheckstarted failing on every open PR in this repo today. Three Go standard library advisories, all reachable from our code, all fixed in go1.26.6:crypto/tlsnet/httpencoding/asn1Nothing in the source changed.
go.modcarried a barego 1.26, which setup-go reads as>=1.26.0 <1.27and satisfies from the runner's tool cache rather than downloading a newer patch —Found in cache @ /opt/hostedtoolcache/go/1.26.5/x64. That was fine until the advisories landed against 1.26.5; from that moment every build inherited a vulnerable toolchain.That's also why this looked like it appeared out of nowhere: #63's
Govulncheckpassed at 09:24 today, and re-running that same job on the same commit an hour later failed. Time-based, not tree-based.Why patch-pin the
godirectiveAll eight
setup-gosteps acrosstest.yml,security.ymlandrelease.ymlusego-version-file: go.mod, so one line covers every one of them. Pinning the patch makes the resolved version exact instead of "newest thing already in the cache".It also matches the rest of the fleet —
kamal-proxy(go 1.26.5),once(go 1.26.4) andbasecamp-installer(go 1.26.4) all patch-pin thegodirective and carry notoolchaindirective. cli was the outlier with a bare minor.I considered
check-latest: trueon the setup-go steps instead, which would self-heal on the next advisory. It's eight edits rather than one, and it trades reproducible builds for a floating toolchain — worth doing deliberately if you want it, but not the minimal fix for a red CI.Verification
Reproduced and confirmed locally against this exact tree:
go build,go vet,gofmt -land the fullgo test ./...suite all pass on 1.26.7.Note
Dependabot will not maintain this pin — its
gomodupdater doesn't bump thegodirective, which is why kamal-proxy still sits on 1.26.5 while 1.26.7 is out. The next stdlib advisory will need the same manual bump here and in those three repos. Worth a separate conversation about whethercheck-latest: trueis the better standing answer fleet-wide.Once this lands, #64 and #63 should go green on rebase.