Make hey box --all fetch every page - #166
Open
code-monger-givenall wants to merge 1 commit into
Open
Conversation
code-monger-givenall
force-pushed
the
agent/complete-box-pagination
branch
from
August 19, 2026 18:09
84e3aad to
3be1f62
Compare
code-monger-givenall
marked this pull request as ready for review
August 19, 2026 18:10
Contributor
There was a problem hiding this comment.
Pull request overview
Updates box pagination so hey box <box> --all follows every cursor safely.
Changes:
- Removes the 100-page limit.
- Detects repeated cursors and continues through empty intermediate pages.
- Adds regression coverage and removes the obsolete truncation notice.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/cmd/box.go |
Implements uncapped, loop-safe pagination. |
internal/cmd/box_test.go |
Tests long pagination, cursor loops, and empty pages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #55.
hey box <box> --allstill stops after 100 history pages. In Imbox, that means 30 initial items plus 100 batches of 10, so larger mailboxes stop at 1,030 even whennext_history_urlis still present.This change follows the cursor until HEY returns no next page. It also:
Tests
env GOWORK=off mise x go@1.26.6 golangci-lint@2.12.2 -- make checkNo mailbox content is changed by this command.