Skip to content

Design auth screens/states; add previewer for working on them - #206

Merged
robzolkos merged 3 commits into
mainfrom
auth-screens-design
Aug 20, 2026
Merged

Design auth screens/states; add previewer for working on them#206
robzolkos merged 3 commits into
mainfrom
auth-screens-design

Conversation

@jzimdars

Copy link
Copy Markdown
Member

This adds design for the locally served auth screens and a previewer for viewing them in dev make preview-callback.

Supports dark and light mode.

screenshot-2026-08-20_10-24-20 screenshot-2026-08-20_10-24-10

Copilot AI balanced review requested due to automatic review settings August 20, 2026 15:32
@jzimdars
jzimdars requested a review from a team as a code owner August 20, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds styled light/dark OAuth callback screens and a development preview server.

Changes:

  • Adds reusable callback templates and HEY branding.
  • Integrates status-specific pages into OAuth handling.
  • Adds rendering tests and a preview Make target.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Makefile Adds the callback preview target.
internal/auth/auth.go Serves status-specific callback pages.
internal/auth/auth_test.go Tests callback responses and bodies.
internal/auth/callback.go Embeds and renders callback templates.
internal/auth/callback.html Defines the responsive light/dark shell.
internal/auth/callback_test.go Validates rendered callback pages.
internal/auth/callback_preview_test.go Implements the local preview server.
internal/auth/callback_success.html Adds the success state.
internal/auth/callback_error.html Adds the general failure state.
internal/auth/callback_denied.html Adds the access-denied state.
internal/auth/callback_invalid.html Adds the invalid-link state.
internal/auth/hey_logo.html Provides light and dark HEY logos.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Makefile Outdated
Comment thread internal/auth/callback_preview_test.go Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e850fdbad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Makefile Outdated
robzolkos and others added 2 commits August 20, 2026 11:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@robzolkos
robzolkos merged commit 425ab72 into main Aug 20, 2026
23 checks passed
@robzolkos
robzolkos deleted the auth-screens-design branch August 20, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants