Skip to content

Refactor setup Git remote parsing helpers#1480

Merged
codeforester merged 1 commit into
mainfrom
enhancement/1466-20260705-git-remote-parsing
Jul 5, 2026
Merged

Refactor setup Git remote parsing helpers#1480
codeforester merged 1 commit into
mainfrom
enhancement/1466-20260705-git-remote-parsing

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • extract Git remote URL parsing/model/detail helpers into base_setup.git_remote_parse
  • keep parser compatibility exports available from base_setup.git_remote
  • add parser-module tests for compatibility exports, credential sanitization, and local path resolution

Validation

  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_git_remote_parse.py -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_git_remote.py -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_manifest_checks.py cli/python/base_setup/tests/test_git_remote.py cli/python/base_setup/tests/test_git_remote_parse.py -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pylint cli/python/base_setup/git_remote.py cli/python/base_setup/git_remote_parse.py cli/python/base_setup/tests/test_git_remote.py cli/python/base_setup/tests/test_git_remote_parse.py
  • python3 -m compileall -q cli/python/base_setup/git_remote.py cli/python/base_setup/git_remote_parse.py cli/python/base_setup/tests/test_git_remote_parse.py
  • git diff --check

Closes #1466

@codeforester codeforester requested a review from a team as a code owner July 5, 2026 21:42
@codeforester codeforester merged commit c593311 into main Jul 5, 2026
26 checks passed
@codeforester codeforester deleted the enhancement/1466-20260705-git-remote-parsing branch July 5, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate setup Git remote parsing from checks

1 participant