Skip to content

Refactor manifest trust store helpers#1481

Merged
codeforester merged 1 commit into
mainfrom
enhancement/1468-20260705-trust-helpers
Jul 5, 2026
Merged

Refactor manifest trust store helpers#1481
codeforester merged 1 commit into
mainfrom
enhancement/1468-20260705-trust-helpers

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • extract manifest command trust identity/store helpers into base_trust.trust_store
  • keep existing base_trust.engine helper names as compatibility re-exports
  • add focused coverage for the new module boundary

Validation

  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_trust/tests/test_engine.py::ManifestCommandTrustTests::test_engine_reexports_trust_store_helpers -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_trust/tests/test_engine.py -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_trust/tests/test_engine.py cli/python/base_projects/tests/test_engine.py cli/python/base_projects/tests/test_build_targets.py -q
  • PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pylint cli/python/base_trust/engine.py cli/python/base_trust/trust_store.py cli/python/base_trust/tests/test_engine.py
  • python3 -m compileall -q cli/python/base_trust/engine.py cli/python/base_trust/trust_store.py cli/python/base_trust/tests/test_engine.py
  • git diff --check
  • env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-1468-trust-smoke bin/basectl trust status base --workspace /Users/rameshhp/work --format json

Closes #1468

@codeforester codeforester requested a review from a team as a code owner July 5, 2026 22:21
@codeforester codeforester merged commit b04fc13 into main Jul 5, 2026
26 checks passed
@codeforester codeforester deleted the enhancement/1468-20260705-trust-helpers branch July 5, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor trust identity store and rendering helpers

1 participant