Skip to content

fix(admin): harden build and password flows - #61

Merged
bashrusakh merged 3 commits into
refactor/deskforge-corrective-prfrom
fix/github-build-save-error
Aug 20, 2026
Merged

fix(admin): harden build and password flows#61
bashrusakh merged 3 commits into
refactor/deskforge-corrective-prfrom
fix/github-build-save-error

Conversation

@bashrusakh

@bashrusakh bashrusakh commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Harden Custom Client Builder validation, safe preset password preservation/clear behavior, and localized accessible feedback.
  • Improve GitHub Build configuration errors, PAT guidance, workflow approval controls, and request error handling.
  • Bind workflow dispatch to the provider-derived SHA in both the public workflow input and encrypted DFP1 payload; caller-authored SHA values remain rejected.
  • Allow legacy existing passwords longer than 32 characters to reach verification while retaining the 32-character limit for new passwords.
  • Record the workflow guard evidence and remaining provider TOCTOU limitation.

Validation

  • GOWORK=off go test ./...
  • GOWORK=off go vet ./...
  • npm run build
  • Changed JavaScript syntax and locale validation
  • git diff --check
  • RustDesk: bash tests/test_workflow_input_contract.sh and PyYAML workflow parsing
  • Live mismatch guard run: 32333446480 failed before bridge/build as expected.
  • Live matching guard run: 32334155671 passed both SHA guards and intentionally failed before checkout/build on empty source_sha.

Scope and limits

  • Companion RustDesk workflow branch: fix/workflow-sha-guard at 8ad23a826d5df1e311a727e507861c0c6bc35c76.
  • The live runs prove guard sequencing only; they do not produce a client artifact.
  • GitHub workflow_dispatch remains selector-based rather than atomically SHA-bound. Verified annotated tags and a no-bypass ruleset remain required before production use.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 36715866-f0cb-4d20-aa74-10a4d0f5897f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bashrusakh bashrusakh changed the title fix(ui): show GitHub build save errors fix(admin): harden build and password flows Aug 20, 2026
@bashrusakh
bashrusakh merged commit 9a02fd7 into refactor/deskforge-corrective-pr Aug 20, 2026
5 checks passed
@bashrusakh
bashrusakh deleted the fix/github-build-save-error branch August 20, 2026 08:24
bashrusakh added a commit that referenced this pull request Aug 20, 2026
* refactor: harden build provenance and releases

* fix(workflow): harden ruleset and build cleanup checks

* fix(custom-build): close zip traversal path

* fix(workflow): provide sqlx schema for rust ci

* fix(custom-build): make zip path validation codeql-visible

* workflow: harden GitHub protection contract

* docs: record corrective PR publication evidence

* workflow: harden ruleset failure handling

* docs: record ruleset review evidence

* workflow: align ruleset validation with repository responses

* ui: clarify custom endpoint ports

* test: cover legacy tag list contract

* api: remove obsolete tag protection fallback

* workflow: pin CI toolchains and build image

* workflow: rename client workflow contract

* docs: record workflow migration status

* docs: record workflow ruleset status

* docs: finalize workflow migration records

* docs: close workflow migration checklist

* fix(admin): harden build and password flows (#61)

* fix(ui): show GitHub build save errors

* fix(admin): harden build and password flows

* docs(workflow): record SHA guard branch checks

---------

Co-authored-by: bashrusakh <bashrusakh@users.noreply.github.com>

* fix(custom-preset): enforce owner name uniqueness

* fix(workflow): require identity guard marker

* docs(plan): record PR59 remediation gates

* docs(plan): sync RustDesk guard PR status

* fix(custom-build): verify published output manifest

* docs(plan): record merged guard prerequisite

---------

Co-authored-by: bashrusakh <bashrusakh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant