Skip to content

Fix repeated permission prompts when screen recording is already authorized #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luw2007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix repeated permission prompts when screen recording is already authorized #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ScreenTextGrab/Services/ScreenPermissionService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ final class ScreenPermissionService: ScreenPermissionProviding {
persistResolvedState(resolvedState)
return resolvedState
case .unknown:
// Probe returned indeterminate result. If we have prior confirmed grant
// evidence (persisted across launches), trust it — CGPreflightScreenCaptureAccess
// and ScreenCaptureKit probes can be transiently unreliable on macOS 14+ for
// ad-hoc signed apps.
let previouslyGranted = defaults.bool(forKey: Self.permissionPreviouslyGrantedKey)
if lastConfirmedGrantAt != nil || previouslyGranted {
lastResolvedState = .granted
persistResolvedState(.granted)
return .granted
}
let resolvedState: ScreenPermissionState = needsRestartAfterGrant ? .requiresRestart : .unknown
lastResolvedState = resolvedState
persistResolvedState(resolvedState)
Expand Down Expand Up @@ -266,11 +276,17 @@ final class ScreenPermissionService: ScreenPermissionProviding {
case .granted, .requiresRestart:
defaults.set(true, forKey: Self.autoPromptAttemptedKey)
defaults.set(true, forKey: Self.permissionPreviouslyGrantedKey)
case .denied, .unknown:
case .denied:
if previouslyGranted {
defaults.set(false, forKey: Self.autoPromptAttemptedKey)
defaults.set(false, forKey: Self.permissionPreviouslyGrantedKey)
}
case .unknown:
// Probe returned indeterminate result; preserve previously granted state
// instead of resetting. CGPreflightScreenCaptureAccess is unreliable on
// macOS 14+ for ad-hoc signed apps, and transient probe failures should
// not cause repeated permission prompts.
break
case .requestInProgress:
break
}
Expand Down