fix(pypi): drop unsupported args in the whl_library macro - #4083
Open
aignas wants to merge 3 commits into
Open
Conversation
With this change we just ignore unsupported args from the implementation rules. Whilst this is a blunt tool to get the job done, it should work for now and it is extendible to do failures or warnings in the future. Fixes bazel-contrib#4077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we just ignore unsupported args from the implementation
rules. Whilst this is a blunt tool to get the job done, it should work
for now and it is extendible to do failures or warnings in the future.
Fixes #4077