Stop templating target_systems.bzl#134
Open
keith wants to merge 1 commit into
Open
Conversation
Member
Author
|
maybe there's some case in google where this file does change based on maybe a local build of the NDK toolchain or something? maybe that still doesn't matter for the default toolchain setup? this would ofc require other importers to update this though. we could leave it around for a bit while still changing our references |
This templated file never varies, so seems like something we can just expose directly instead.
keith
force-pushed
the
ks/stop-templating-target_systems.bzl
branch
from
0e5f72f to
10f2a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This templated file never varies, so seems like something we can just
expose directly instead.