Accept both simulator UUIDs and simulator device names in @rules_apple//apple/build_settings:ios_device#3002
Draft
ssarad wants to merge 2 commits into
Draft
Accept both simulator UUIDs and simulator device names in @rules_apple//apple/build_settings:ios_device#3002ssarad wants to merge 2 commits into
@rules_apple//apple/build_settings:ios_device#3002ssarad wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@rules_apple//apple/build_settings:ios_devicebuild setting was supposed to accept both simulator UUIDs and simulator device names (like "iPhone 15 Pro"), but it only worked with UUIDs. The problem was inapple/internal/ios_rules.bzlwhere theios_devicevalue was always passed assimulator_identifier(which expects a UUID) instead of being passed to the appropriate parameter based on its format.This is particularly nice for companies that require proxy certs in simulators and allows you to reuse pre-loaded simulators with all the certs
Updated the simulator executable registration to: