Skip to content

Check private create_library_to_link arguments once #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzbarsky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check private create_library_to_link arguments once #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions cc/private/cc_common.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,22 +191,19 @@ def _create_library_to_link(
dynamic_library_symlink_path = "",
interface_library_symlink_path = "",
must_keep_debug = _UNBOUND):
if lto_compilation_context != _UNBOUND:
if lto_compilation_context != _UNBOUND or \
pic_lto_compilation_context != _UNBOUND or \
must_keep_debug != _UNBOUND or \
objects != _UNBOUND or \
pic_objects != _UNBOUND:
_cc_internal.check_private_api(allowlist = _PRIVATE_STARLARKIFICATION_ALLOWLIST)
else: # lto_compilation_context == _UNBOUND

if lto_compilation_context == _UNBOUND:
lto_compilation_context = None
if pic_lto_compilation_context != _UNBOUND:
_cc_internal.check_private_api(allowlist = _PRIVATE_STARLARKIFICATION_ALLOWLIST)
else: # pic_lto_compilation_context == _UNBOUND
if pic_lto_compilation_context == _UNBOUND:
pic_lto_compilation_context = None
if must_keep_debug != _UNBOUND:
_cc_internal.check_private_api(allowlist = _PRIVATE_STARLARKIFICATION_ALLOWLIST)
else:
if must_keep_debug == _UNBOUND:
must_keep_debug = False
if objects != _UNBOUND:
_cc_internal.check_private_api(allowlist = _PRIVATE_STARLARKIFICATION_ALLOWLIST)
if pic_objects != _UNBOUND:
_cc_internal.check_private_api(allowlist = _PRIVATE_STARLARKIFICATION_ALLOWLIST)

# We cannot check if experimental_starlark_cc_import is set or not here,
# since there is not ctx. So for a native code to perform the check
Expand Down