Load the known projects before listing them - #2171
Merged
Merged
Conversation
`projectile-known-projects' is both a variable and the accessor that lazily loads it from disk, and nothing loads it at startup. Five commands read the variable, so whichever of them a session reached for first was handed nil: `projectile-find-file-in-known-projects' completed over an empty list, and so did `projectile-vc', `projectile-remove-known-project' and the "Switch to project" prompt `projectile-require-project-root' can raise. Measured on a cold Emacs with 124 saved projects: `projectile-all-project-files' returned 0 files before the accessor had been called and 118604 after. Anything that ran `projectile-switch-project' first hid it, which is presumably how it survived this long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projectile-known-projectsis both a variable and the accessor that lazily loads it from disk, and nothing loads it at startup. Five commands read the variable, so whichever one a session reached for first got nil.On a cold Emacs with 124 saved projects,
projectile-all-project-filesreturned 0 files before the accessor had been called and 118604 after. Sos-p Fcompleted over an empty list - as didprojectile-vc,projectile-remove-known-projectand the "Switch to project" promptprojectile-require-project-rootcan raise.Running
projectile-switch-projectfirst hides it, which is presumably how it survived this long.