Cover the rest of the commands worth driving - #2174
Merged
Merged
Conversation
Sixteen more functions the suite never entered, all reached through a command: find-dir, find-file-dwim, recentf, edit-dir-locals, run-command-in-root, version, previous-project-buffer, the impl/test toggle, the three remaining lifecycle commands and repeat-last-command. Writing them cost two corrections worth keeping. `recentf' gates on `(boundp 'recentf-list)', and a `let' cannot make an unbound non-special symbol bound, so the spec has to load recentf rather than bind the variable. And `repeat-last-command' reads a ring through `projectile--get-command-history' rather than any "last command" accessor, so the first version of that spec was testing a function that does not exist. Function coverage 90.0% -> 91.9%, 84 functions never entered -> 68. What is left is mostly code that spawns a terminal or a process, the Mercurial paths, and the dashboard and doctor renderers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixteen more functions the suite never entered, all reached through a command:
find-dir,find-file-dwim,recentf,edit-dir-locals,run-command-in-root,version,previous-project-buffer, the impl/test toggle, the three remaining lifecycle commands andrepeat-last-command.Two corrections came out of writing them.
projectile-recentfgates on(boundp 'recentf-list), and aletcannot make an unbound non-special symbol bound - the spec has to load recentf. Andrepeat-last-commandreads a ring viaprojectile--get-command-history, not any "last command" accessor, so my first attempt was asserting against a function that doesn't exist.90.0% -> 91.9%, 84 never entered -> 68. The remainder is mostly code that spawns a terminal or a process, the Mercurial paths, and the dashboard/doctor renderers.