Rector rules and tooling based to create rectors base on dbuytaert/drupal-digests

[bbrala]

Overview

This PR implements Drupal deprecation rules for drupal-rector, covering Drupal 10 and Drupal 11 (11.1–11.4). It adds 52 new Drupal 11 rector classes, 4 new Drupal 10 rector classes, and 2 new generic data-driven rectors, all wired into the per-version deprecation config files. Each rule targets a specific Drupal change record and includes type-guarded transformations and version-gating tests.

The work originated as an experiment converting drupal-digests AI-generated rules into fully drupal-rector-compliant implementations — validating the conversion workflow and tooling in the process.

Also worked on a better way to control if/how BC code paths are implemented.

This PR also removed rector 1 support. Which is a little before Drupal 10 EOL in august, but made life a lot easier.

---

Infrastructure improvements

Generic data-driven rectors

• FunctionCallRemovalRector (src/Rector/Deprecation/) — removes calls to deprecated functions with no replacement; handles 11 deprecated functions across Drupal 11.2–11.4
• FunctionToFirstArgMethodRector — refactored to src/Rector/Deprecation/ as a shared base for Drupal 8/9/10/11 use

BC wrapping extended

Previously, backwardsCompatibleCall() wrapping in AbstractDrupalCoreRector only applied when both old and new nodes were of matching types. Extended to cover all Expr node types so mixed-type rewrites (e.g. function call → method call) also get proper BC wrapping.

Version-gating tests

Added DrupalRectorSettings::setDrupalVersion() (via static::getContainer()->make(DrupalRectorSettings::class)) for clean version-specific test scenarios. Replaces the previous namespaced-class \Drupal hack that was causing test brittleness.

DrupalRectorSettings is a container-managed service that centralises the runtime settings rectors need to make version-aware decisions. It holds three values: whether backwards-compatibility wrapping is enabled, the minimum Drupal core version the project still supports, and an optional Drupal version override.

Config-driven refactoring

Three custom constant-replacement rectors were replaced with ConstantToClassConstantRector configuration entries, reducing custom code:

• ReplaceRequirementSeverityConstantsRector → config
• ReplaceJsonApiFilterConstantsRector → config
• ReplaceNodeSetPreviewModeRector for the enum path → config

---

Tooling (.claude/skills/)

Adds three Claude Code skills used to drive the conversion workflow:

• rector-discover lists unimplemented drupal-digests rules by implementation phase; regenerates docs/rector-index.yml when stale
• rector-implement AI prompt that converts a drupal-digests rule into a fully compliant rector class, test, fixture, and config entry
• rector-qa QA checklist and fixture expansion workflow for completed rectors

---

New Drupal 11 rules

11.1

• AliasManager::pathAliasWhitelistRebuild() → pathAliasPrefixListRebuild() (via RenameMethodRector config)
• ReplaceCommentManagerGetCountNewCommentsRector — replaces CommentManagerInterface::getCountNewComments() with a service call (issue #3543035)

11.2

• template_preprocess_{container,html,page,links,time,datetime_form,datetime_wrapper}() → ThemePreprocess* attribute hooks (DeprecatedFilterFunctionsRector and related)
• CacheBackendInterface::invalidateAll() → deleteAll()
• StatementPrefetchIteratorFetchColumnRector — fetchColumn() → fetchField(), skipping PDO's native $column arg form
• RemoveModuleHandlerAddModuleCallsRector — removes no-op addModule()/addProfile() calls
• RemoveHandlerBaseDefineExtraOptionsRector — removes deprecated defineExtraOptions() with no replacement
• ReplaceAlphadecimalToIntNullRector — Number::alphadecimalToInt(null/'') → 0
• LoadAllIncludesRector — ModuleHandler::loadAllIncludes() → explicit foreach getModuleList() + loadInclude() loop
• RemoveCacheExpireOverrideRector — removes deprecated CACHE_* constant override in settings
• RemoveConfigSaveTrustedDataArgRector — strips the deprecated $trusted_data arg from Config::save()
• ReplaceDateTimeRangeConstantsRector — DateTimeRangeItem::DATETIME_TYPE_* constants → DateTimeRangeItem::*
• Various FunctionCallRemovalRector entries (removed deprecated theme preprocess and update manager functions)

11.3

• NodeMassUpdateRector (via ReplaceNodeModuleProceduralFunctionsRector) — node_mass_update() → NodeBulkUpdate::process()
• JSONAPI_FILTER_AMONG_* constants → JsonApiFilter::* (via ConstantToClassConstantRector config, issue #3560657)
• StripMigrationDependenciesExpandArgRector — removes deprecated $expand_dependencies argument

11.4

• FunctionToServiceRector config for 29 deprecated procedural functions across 9 modules (issue numbers in config)
• RemoveLinkWidgetValidateTitleElementRector — validation moved to element-level, call removed
• RemoveAutomatedCronSubmitHandlerRector — removes deprecated $form['#submit'][] = 'automated_cron_settings_submit'
• DRUPAL_DISABLED/OPTIONAL/REQUIRED in NodeTypeInterface::setPreviewMode() → PreviewMode::* enum (via ConstantToClassConstantRector config)
• ReplaceRecipeRunnerInstallModuleRector — RecipeRunner::installModules() → RecipeRunner::processRecipe()
• ReplaceEntityReferenceRecursiveLimitRector — EntityReferenceEntityFormatter::RECURSIVE_RENDER_LIMIT → literal 20
• RemoveUpdaterPostInstallMethodsRector — removes deprecated postInstall()/postUpdate() Updater calls
• ReplaceSystemPerformanceGzipKeyRector — system.performance css.gzip/js.gzip keys → gzip
• ReplaceViewsProceduralFunctionsRector — views_embed_view(), views_get_view_result() etc. → service calls

11.x (multi-version)

• NodeStorageDeprecatedMethodsRector — revisionIds()/userRevisionIds()/countDefaultLanguageRevisions() → entity query chains (11.1)
• PluginBaseIsConfigurableRector — isConfigurable() → instanceof ConfigurableInterface (11.2)
• ReplaceSessionManagerDeleteRector — SessionManager::delete($uid) → UserSessionRepository::deleteByUid() (11.3)
• ReplaceEntityOriginalPropertyRector — $entity->original → getOriginal()/setOriginal(), with NullsafePropertyFetch support (11.1)
• ReplaceEditorLoadRector — editor_load() → entityTypeManager()->getStorage('editor')->load() (11.4)
• ReplaceThemeGetSettingRector — theme_get_setting() → ThemeSettingsProvider service (11.3)
• ReplaceSessionWritesWithRequestSessionRector — direct $_SESSION writes → RequestSession service
• ReplaceUserSessionNamePropertyRector — $this->name in UserSession subclasses → $this->getAccountName() (with $this guard to prevent recursion)
• MigrateSqlGetMigrationPluginManagerRector — $this->getMigrationPluginManager() → $this->migrationPluginManager property, scoped to Drupal\migrate\Plugin\migrate\id_map\Sql
• UseEntityTypeHasIntegerIdRector — $entityType->getKey('id') === 'nid' pattern → hasIntegerId()
• ReplaceNodeAddBodyFieldRector — node_add_body_field() → direct field config API
• ReplaceNodeAccessViewAllNodesRector — node_access_view_all_nodes() → AccessResult::allowed()
• ReplaceFieldgroupToFieldsetRector — fieldgroup display component migration
• ReplaceLocaleConfigBatchFunctionsRector — locale_config_batch_refresh_name() etc. → service calls
• ReplacePdoFetchConstantsRector — \PDO::FETCH_* constants in Drupal DB context → Fetch::* enum values
• ReplaceJsonApiFilterConstantsRector → (refactored to ConstantToClassConstantRector config)
• RemoveStateCacheSettingRector — removes $settings['state_cache'] (permanently enabled since 11.0)
• RemoveModuleHandlerDeprecatedMethodsRector — other deprecated ModuleHandler methods
• RemoveSetUriCallbackRector — removes setUriCallback() standalone and mid-chain
• RemoveRootFromConvertDbUrlRector — strips deprecated $root arg from Database::convertDbUrlToConnectionInfo()
• RemoveTrustDataCallRector, RemoveTwigNodeTransTagArgumentRector, RemoveFilterTipsLongParamRector
• RemoveViewsRowCacheKeysRector, RenameStopProceduralHookScanRector
• ReplaceRequirementSeverityConstantsRector — REQUIREMENT_* globals → RequirementSeverity::* enum
• Various class renames (migrate_drupal ContentEntity/Deriver, locale translation files) via RenameClassRector config
• ReplaceFileGetContentHeadersRector — file_get_content_headers($file) → $file->getDownloadHeaders()
• FilterFormatFunctionsToServiceRector, DeprecatedFilterFunctionsRector, FileManagedFileSubmitRector, MediaFilterFormatEditFormValidateRector, NodeAccessRebuildFunctionsRector, ErrorCurrentErrorHandlerRector, FileSystemBasenameToNativeRector, ReplaceTwigExtensionRector

---

New Drupal 10 rules

• ReplaceModuleHandlerGetNameRector — ModuleHandlerInterface::getName($module) → \Drupal::service('extension.list.module')->getName($module) (issue #3571063)
• ReplaceRebuildThemeDataRector — ThemeHandlerInterface::rebuildThemeData() → ThemeExtensionList::reset()->getList()
• ReplaceRequestTimeConstantRector — REQUEST_TIME constant → \Drupal::time()->getRequestTime()
• VersionedFunctionToServiceRector + VersionedFunctionToServiceConfiguration — version-gated variant of FunctionToServiceRector for cases where the service name depends on the Drupal target version

---

Testing

• Each new rector has a fixture test with happy-path and at least one no_change case
• QA pass expanded fixture coverage for 30+ rectors: added edge cases for FQCN-prefixed calls, self::/static:: forms, method-call-as-argument, class-property usage, and unrelated-class no-change guards
• Several bugs were caught and fixed during QA (see individual fix commits)