Skip to content

DBC22-6524: removed debugging console logs and warnings as possible#1362

Merged
wmuldergov merged 1 commit into
mainfrom
bugfix/DBC22-6524
Jun 24, 2026
Merged

DBC22-6524: removed debugging console logs and warnings as possible#1362
wmuldergov merged 1 commit into
mainfrom
bugfix/DBC22-6524

Conversation

@bcgov-brwang

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Deploy to dev.
  2. Login to https://dev.drivebc.ca/drivebc-cms/.
  3. Create/Edit an advisory and save to draft or publish.
  4. Verify the advisory can be saved or published successfully without 500 server errors.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@bcgov-brwang bcgov-brwang requested a review from wmuldergov June 3, 2026 16:18
@bcgov-brwang bcgov-brwang added the ready for review The PR is ready for review label Jun 3, 2026
@bcgov-brwang bcgov-brwang marked this pull request as ready for review June 3, 2026 16:18
@wmuldergov

Copy link
Copy Markdown
Collaborator

I am still getting an error when I start an advisory, but I think that is because you cannot save an advisory without a polygon. One you have a polygon set, then the errors go away.
Is there a way to add logic that autosave doesn't require the polygon to work?

@wmuldergov wmuldergov added pending rework If the PR needs some re-work by the developer and removed ready for review The PR is ready for review labels Jun 3, 2026
@bcgov-brwang bcgov-brwang added ready for review The PR is ready for review and removed pending rework If the PR needs some re-work by the developer labels Jun 17, 2026
@wmuldergov

Copy link
Copy Markdown
Collaborator

While autosave is fixed...now I am able to publish an advisory without a polygon. I believe we should not be allowing users to publish without a polygon set.

@wmuldergov wmuldergov added pending rework If the PR needs some re-work by the developer and removed ready for review The PR is ready for review labels Jun 19, 2026
@bcgov-brwang bcgov-brwang added ready for review The PR is ready for review and removed pending rework If the PR needs some re-work by the developer labels Jun 22, 2026
@wmuldergov wmuldergov added pending rework If the PR needs some re-work by the developer and removed ready for review The PR is ready for review labels Jun 22, 2026
@bcgov-brwang bcgov-brwang added ready for review The PR is ready for review and removed pending rework If the PR needs some re-work by the developer labels Jun 23, 2026
DBC22-6524: fixed null geo saving for advisory

DBC22-6524: reverted to pre version

DBC22-6524: validate geo field before post request
@wmuldergov wmuldergov closed this Jun 24, 2026
@wmuldergov wmuldergov reopened this Jun 24, 2026
@wmuldergov wmuldergov merged commit 46c65b9 into main Jun 24, 2026
14 of 16 checks passed
@wmuldergov wmuldergov deleted the bugfix/DBC22-6524 branch June 24, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants