AzureIDIR (IDIR MFA) support#250
Open
norrisng-bc wants to merge 2 commits into
Open
Conversation
Also: in bucketStore, rename permResponse to userPermResponse for clarity (and to reflect difference between user perms and IDP perms)
Already enabled on local environment, but crucially, the corresponding idir/azureidir user is now treated as the same user (instead of completely different ones).
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
Release eb21b9c deployed at https://bcbox-dev-pr-250.apps.silver.devops.gov.bc.ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces full support for IDIR MFA (a.k.a.
azureidir) as an identity provider, alongside the existing SiteMinder IDIR (oridir).Partial support was already available in the local dev environment, but behaviour was buggy. Some examples of this include:
idiruser didn't carry over to theazureidir-equivalent userSimilar to the COMS-side changes made to enable IDIR MFA (bcgov/common-object-management-service#320), this was achieved by 'coercing'
authStore.profile.identity_providertoidirwheneverazureidirwas present in the corresponding JWT field.Additionally, all calls to
bucketStore.fetchBuckets()(typically executed when bucket-related components are mounted, or when the user performs an action that changes the state of the bucket store) now pass theidp.This fixes a bug with the bucket table, where a folder that's only displayed because the user has IDP-level permissions (but not user-specific permissions) reverts to being a dummy folder, upon any user actions that change a bucket or folder (e.g. creating/deleting subfolders).
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3713
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-4365
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments
See also: bcgov/common-object-management-service#320