Skip to content

35081 - Update Filer for Review Imported Data Filing - #4869

Merged
mruff-aeq merged 10 commits into
bcgov:mainfrom
meawong:35081-Filer-Updates-for-Review-Imported-Data
Oct 20, 2026
Merged

mruff-aeq merged 10 commits into
bcgov:mainfrom
meawong:35081-Filer-Updates-for-Review-Imported-Data

Conversation

@meawong

@meawong meawong commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#35081

Description of changes:

  • Add Business Filer support for processing reviewImportedData filings, including updating registered office and records office addresses and director addresses.
  • Add validation that the registered office and records office mailing addresses have a BC region and Canadian country ( already applies for delivery address)
  • Add ff gate review-imported-data in enable-new-feature
  • Add/update unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@meawong meawong self-assigned this Oct 15, 2026
allowed_types=["registeredOffice", "recordsOffice"],
required_types=[],
bc_req=False,
bc_req=True,

@meawong meawong Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating as records/registered offices require a BC address for delivery addresses.

@meawong
meawong requested review from kialj876 and mruff-aeq October 15, 2026 00:58

@kialj876 kialj876 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but a few comments to confirm below

Comment thread legal-api/src/legal_api/services/filings/validations/review_imported_data.py Outdated

@mruff-aeq mruff-aeq left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just address the pyproject.toml resolve conflict

@meawong
meawong force-pushed the 35081-Filer-Updates-for-Review-Imported-Data branch from 7743e1d to 75e6fad Compare October 20, 2026 15:38
@mruff-aeq
mruff-aeq merged commit 587daa7 into bcgov:main Oct 20, 2026
8 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants