Track the current 1.x-dev of bear/query-repository - #128
Conversation
SafeSemanticLogger's constructor changed there: it takes an optional LogSinkInterface and a session store, not a delegate logger. Both places that bind the cache log by hand passed a logger, so the release candidate answers them with a TypeError before a single flow runs - every oracle flow and the corpus cache test died in the DI graph. Bound with to() in Singleton scope instead of an instance: the two sites resolve the logger from the injector, and a service object on a binding keeps DI out of its construction and stops the injector from serialising. Verified against the pinned 5abe573: tests/Resource/AgentCorpusCacheTest 4 tests green, and the gate reports 12 flows ok with exit 0 (the library line reads NOT A CHECKOUT, which is what a dist install looks like). composer.lock also records my-vendor/be-mart-be's path-package hash recomputed on a clean checkout.
|
@coderabbitai review |
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughキャッシュログ用の Changesキャッシュログ束縛
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The dependency update adapts cache-log logger construction to injector-managed singleton bindings and includes the cache-refresh fix. The updated cache test and verification script cover the binding change, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
SafeSemanticLogger's constructor changed inbear/query-repository1.x: it takes an optionalLogSinkInterfaceand a session store, not a delegate logger. Both places that bind the cache logby hand passed a logger, so the current 1.x answers them with a
TypeErrorinside the DI graph —every oracle flow and the corpus cache test dies before it runs anything.
The lock moves from
bec4c4dto5abe573, which also brings the donut write-weaving fix(bearsunday/BEAR.QueryRepository#215): a write annotated
#[RefreshCache]used to be answered fromthe cache without running.
Both bindings now use
to()in Singleton scope rather than an instance. Both sites resolve thelogger from the injector, so nothing needs the instance; binding a service object also keeps DI out
of its construction and stops the injector from serialising.
Verified against the pinned
5abe573:./vendor/bin/phpunit tests/Resource/AgentCorpusCacheTest.php— 4 tests, 10 assertions, greenGATE_SUITE=0 ./var/loop/verify-all.sh— 12 flows ok, exit 0. Thelibraryline readsNOT A CHECKOUT, which is what a dist install looks like; the verdict is not attributed to alibrary commit
composer cs:phpfails on 4 files, identically before and after this branch (pre-existinggetenv()violations, none of them touched here)composer.lockalso recordsmy-vendor/be-mart-be's path-package hash as recomputed on a cleancheckout.
Summary by CodeRabbit
テスト
改善