Skip to content

Find and fix broken links - #12

Merged
koriym merged 3 commits into
masterfrom
claude/fix-broken-links-Gh1TM
Jan 5, 2026
Merged

koriym merged 3 commits into
masterfrom
claude/fix-broken-links-Gh1TM

Conversation

@koriym

@koriym koriym commented Jan 5, 2026 •

Copy link
Copy Markdown
Contributor

Update links from ./05-metamorphosis.html to ./05-metamorphosis-patterns.html to match the actual filename (05-metamorphosis-patterns.md).

Affected files:

  • en/faq.md (3 links)
  • en/index.md (1 link)
  • ja/faq.md (3 links)
  • ja/index.md (1 link)

Summary by CodeRabbit

  • Documentation
    • Fixed incorrect hyperlinks in the Final Objects documentation across English and Japanese language versions to ensure proper navigation.

✏️ Tip: You can customize this high-level summary in your review settings.

Update links from ./05-metamorphosis.html to ./05-metamorphosis-patterns.html
to match the actual filename (05-metamorphosis-patterns.md).

Affected files:
- en/faq.md (3 links)
- en/index.md (1 link)
- ja/faq.md (3 links)
- ja/index.md (1 link)
@coderabbitai

coderabbitai Bot commented Jan 5, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request updates hyperlinks in two documentation files (English and Japanese versions) to reflect a file reorganization, changing references from Metamorphosis-patterns.html to Metamorphosis.html and from 05-metamorphosis-patterns.html to 05-metamorphosis.html respectively.

Changes

Cohort / File(s) Summary
Documentation link updates
manuals/1.0/en/04-final-objects.md, manuals/1.0/ja/04-final-objects.md
Updated hyperlink targets to reflect file reorganization: Metamorphosis-patterns.html → Metamorphosis.html (EN) and 05-metamorphosis-patterns.html → 05-metamorphosis.html (JA)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #5: Renames the source documentation files from 05-metamorphosis-patterns.html to 05-metamorphosis.html, which is the file reorganization these link updates address.

Poem

🐰 A link once broken, now made right,
From patterns old to metamorphic light,
In English, Japanese, both paths aligned,
The docs now shine, no broken thread we find! ✨

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Find and fix broken links' is generic and vague. While the PR does address broken links, the title doesn't specify which links are being fixed or what the actual change entails (reverting previous corrections and changing link targets). Use a more specific title that describes the actual change, such as 'Update internal links to point to metamorphosis.html instead of metamorphosis-patterns.html' to clearly convey the specific link correction being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9526b7 and 70f1a28.

📒 Files selected for processing (2)
  • manuals/1.0/en/04-final-objects.md
  • manuals/1.0/ja/04-final-objects.md
✅ Files skipped from review due to trivial changes (2)
  • manuals/1.0/en/04-final-objects.md
  • manuals/1.0/ja/04-final-objects.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jan 5, 2026

Copy link
Copy Markdown

Pull Request Review

Thank you for working on fixing broken links! I've reviewed this PR and found a critical issue that needs to be addressed before merging.

Critical Issue: Links Will Break ❌

The PR is updating links from ./05-metamorphosis.html to ./05-metamorphosis-patterns.html, but this will actually break the links rather than fix them.

Why? The actual files have Jekyll permalinks defined in their frontmatter:

  • File: manuals/1.0/en/05-metamorphosis-patterns.md
  • Permalink: /manuals/1.0/en/05-metamorphosis.html (line 4)

Jekyll uses the permalink value in the frontmatter to generate URLs, not the filename. So the correct working URL is 05-metamorphosis.html, not 05-metamorphosis-patterns.html.

Files Affected:

  • manuals/1.0/en/05-metamorphosis-patterns.md:4
  • manuals/1.0/ja/05-metamorphosis-patterns.md:4

Recommended Solution:

Option 1 (Recommended): Revert this PR

  • The current links to ./05-metamorphosis.html are actually correct
  • They work because of the permalink configuration in the markdown frontmatter
  • No changes are needed

Option 2: Update permalinks to match filenames

  • Change the permalink in both files from 05-metamorphosis.html to 05-metamorphosis-patterns.html
  • This would make the URLs match the filenames for consistency
  • However, this would break any external links to the old URL

Code Quality Assessment:

✅ Consistency: Changes are consistent across English and Japanese versions
✅ Scope: Appropriately targeted - only affects link references
✅ Pattern: Follows the project's linking convention (./filename.html)
❌ Correctness: Changes would break links due to permalink mismatch

Conclusion:

This PR appears to be based on a misunderstanding of how Jekyll permalinks work. The filename 05-metamorphosis-patterns.md doesn't determine the URL - the permalink field in the frontmatter does.

Recommendation: Close this PR without merging or revert the changes, as the current links are correct.


Review generated by Claude Code

claude added 2 commits January 5, 2026 14:08
Update link from ./05-metamorphosis-patterns.html to ./05-metamorphosis.html
to match the actual permalink in the frontmatter.
@koriym
koriym merged commit 23626d4 into master Jan 5, 2026
1 check passed
@koriym
koriym deleted the claude/fix-broken-links-Gh1TM branch January 5, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants