-
Notifications
You must be signed in to change notification settings - Fork 1
Improve manual clarity and add Getting Started navigation #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
23a3aae
Fix reader confusion points in chapters 1, 3, and 4
claude 64ddd8d
Fix BeenProcessed description: application-defined, not framework-pro…
claude 1a0ae05
Rename BeenProcessed to BeenConfirmed for domain-specific naming
claude bf26221
Add brief explanation of #[Input]/#[Inject] mechanics in chapter 3
claude 75bfc08
Fix chapter 5 example to use consistent Reason-layer pattern
claude 1763bf1
Unify terminology: destiny markers → Reason objects
claude 283b69a
Add explanation that any Reason object can serve as #[Inject] or $being
claude e402c3e
Add Getting Started and Tutorial links at end of overview chapter
claude bc48e13
Fix $been terminology and ApprovalNotification example consistency
claude bf79188
Fix ApplicationReview example to pass $email through Reason objects
claude b091060
Add Potential/Moment pattern to Reason Layer chapter (EN/JA)
claude 7db7ba5
Add MomentInterface definition to Reason Layer chapter (EN/JA)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Define the PaymentCapture class structure.
The example shows
PaymentCapturebeing constructed (lines 167-171) and used (lines 180-181), but never defines the class itself. Readers need to see howPaymentCaptureholds the authorization code and implementsbe()to understand the Potential pattern.📖 Suggested addition after line 173
Add the PaymentCapture class definition before the usage example:
Then the usage example at lines 178-182 becomes clear: the authorization code is immediately available as a public property, and calling
be()executes the deferred capture closure.🤖 Prompt for AI Agents