BREAKING CHANGE: v0.16 -> CBQ input/output implementation - #95
Closed
alejandrogzi wants to merge 2 commits into
Closed
BREAKING CHANGE: v0.16 -> CBQ input/output implementation#95alejandrogzi wants to merge 2 commits into
alejandrogzi wants to merge 2 commits into
Conversation
Owner
|
@alejandrogzi Thanks for this PR. I'm sorry for unfortunate timing with changes I wanted to release in 0.16.0, but I'm keen to imminently add cbq input and output support to Deacon. If you'd like your commits in the graph, would you mind rebasing this PR onto current main? I'll likely make some further changes on top of yours, but this all looks good. |
alejandrogzi
force-pushed
the
v0.0.16-cbq-input
branch
from
August 12, 2026 12:07
8d657f5 to
6e7b914
Compare
alejandrogzi
force-pushed
the
v0.0.16-cbq-input
branch
from
August 12, 2026 12:18
6e7b914 to
281b231
Compare
Contributor
Author
|
All good. Forced-pushed the changes and updated the changelog to match. All tests pass on my side. |
Owner
|
Apologies, I ended up rebasing myself. Feedback on #98 incorporating your commits welcome. |
Owner
|
Closing now that I've wrapped some of this into #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the necessary implemenation for
deacon filterto accept CBQ (BINSEQ) input, detected automatically, and writes CBQ when the output path ends in.cbq. Benchmark output is consistent between any format combination.Main change against #31 is only CBQ support, dropping VBQ/BQ.
Benchmark: FASTQ vs CBQ, deacon filter 0.16.0
Input: 500k real viral reads (~4 kb each, 1.9 GB) from rsviruses17900 (Zenodo), filtered against an index built from the 17,900 virus contigs (rsviruses17900.fa.gz); keep-all thresholds (-a 1 -r 0), -t 8, 16-core box; hyperfine min/median of 3 + one /usr/bin/time -v pass for peak RSS.
Findings
*Paired reads were derived by half-splitting real reads.