Fix build on Node 26 - #3
Merged
Merged
Conversation
Collaborator
|
@dpeukert Thank you so much for the PR! So sorry I didn't see it. I'm going to fix up some CI issues and then get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR enables the package to build with Node 26 by switching to non-deprecated V2 variants of V8's Utf8Length and WriteUtf8, which along with bumping better-sqlite3 to 12.10.0 enables BKS to build.
Haven't done any further testing apart from running BKS unit tests and seeing that it runs, but I've sent the MR anyway in case it's useful, if not, feel free to close.