Report the label languages - #65
Merged
Merged
Conversation
tile57_mariner.preferred_language accepts any code, and a host had no list to build a language menu from. A code the chart does not state draws the portrayed name, so a mariner could pick one and see a screen of unchanged labels. The bake collects the languages its portrayal passes ran for and splices them into the archive metadata under a "languages" key, beside "scamin". Chart.languages reads them back, and tile57_chart_languages hands them across the ABI as NUL-terminated codes, mirroring tile57_chart_scamin. The compositor borrows its charts, so a host unions the sets from the charts it opened, as it does for SCAMIN. A baked S-57 cell with a national name states und. A native S-101 dataset naming its features in six languages states the four the bake keeps. A chart naming every feature in English states none and the key is left out.
labelTextField composes the depth twin and one per language the chart states. The comment still named text_nat, the single twin it composed before the language passes.
The base picked up main, and both sides had appended to the end of src/chart.zig — the scanLanguageArray test here, main's inventory section and its tests on the base — so the merged file keeps both blocks. Everything else merged without a conflict. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LovcP7ikg3Co7HzLE9egmG
beetlebugorg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tile57_mariner.preferred_languageaccepts any ISO 639-2 code, and a host has no list to build a language menu from. A code the chart does not state draws the portrayed name, so a mariner can pick one and see a screen of unchanged labels. Stacked on #64, which adds the setting.The bake collects the languages its portrayal passes ran for and splices them into the archive metadata under a
languageskey, besidescamin.Chart.languagesreads them back andtile57_chart_languageshands them across the ABI as NUL-terminated codes, mirroringtile57_chart_scamin. The compositor borrows its charts, so a host reading a quilt unions the sets from the charts it opened, as it does for SCAMIN.A baked S-57 cell with a national name states
und, which answers any language because S-57 records none forNOBJNM. A native S-101 dataset naming its features in six languages states the four the bake keeps. A chart naming every feature in English states none, and the key is left out rather than written empty.zig build,zig build testandzig fmt --checkpass.