Collect the src/chart.zig tests again - #77
Merged
Merged
Conversation
The seven tests in src/chart.zig have not run since their test module left build.zig over a link failure on x86_64-linux. lua_shim.c is compiled into every binary that links the portray module, and it references 30 symbols exported from portray.zig, s101/catalogue.zig and portray/rules_embed.zig. Zig emits an export only after analyzing the declaration, and these tests reach none of the three files, so the link had 30 undefined symbols. src/chart.zig references portray and the s101 catalogue in a comptime block, so Zig analyzes both files and emits their exports. rules_embed follows from portray. The test module goes back into build.zig. zig build install test reports 443 tests, up from 436. zig build test -Dtarget=x86_64-linux-gnu compiles every test binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven tests in
src/chart.zighave not run since their test module leftbuild.zigover a link failure on x86_64-linux.lua_shim.cis compiled into every binary that links the portray module, and it references 30 symbols exported fromportray.zig,s101/catalogue.zigandportray/rules_embed.zig. Zig emits an export only after analyzing the declaration, and these tests reach none of the three files, so the link had 30 undefined symbols.src/chart.zigreferences portray and the s101 catalogue in a comptime block, so Zig analyzes both files and emits their exports.rules_embedfollows from portray. The test module goes back intobuild.zig.zig build install testreports 443 tests, up from 436, and all seven recovered tests pass.zig build test -Dtarget=x86_64-linux-gnucompiles every test binary.zig fmt --check src/ tools/ build.zigpasses.