Report every language a chart states - #78
Merged
Merged
Conversation
adapter.languages stopped at four codes. A chart that states more than four had the rest dropped from the archive metadata and from the bake's portrayal passes. 101AA00DS0001 in the S-101 1.2 test set states six: fin, iku, sme, smn, sms and swe. The two dropped were sme=Anár and sms=Lâu'ŋŋsuõllu, nameUsage 2 entries the portrayal catalogue selects on an exact language match. Baking that set without the cap grows the six-language chart from 54658 to 54954 bytes, and the 32 chart bake from 1.36s to 1.42s of user time. Bake size over the set is unchanged at KB resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapter.languagesstopped at four codes, and a chart that states more than four had the rest dropped from the archive metadata and from the bake's portrayal passes. The doc comment gave the reason as cost: each language is a portrayal pass at bake time and a text property per label in the tile.101AA00DS0001 in the S-101 1.2 test set states six languages: fin, iku, sme, smn, sms and swe. The two the cap dropped were
sme=Anárandsms=Lâu'ŋŋsuõllu, both nameUsage 2 entries, whichPortrayalModel.GetFeatureNamereturns on an exact match against PreferredLanguage. A mariner could select neither.Baking
S-101_1.2/000without the cap grows the six-language chart from 54658 to 54954 bytes, and the 32 chart bake from 1.36s to 1.42s of user time. Bake size over the set is unchanged at KB resolution. Thelimitations.mdentry goes with the cap.zig build,zig build testandzig fmt --check src/ tools/ build.zigpass.tile57_chart_languageson the rebaked 101AA00DS0001 reports all six codes, and rendering the chart at each one gives six distinct outputs, with fin matching the default because the portrayed name is the Finnish name.