added tests for completions being called and fixed an issue with let#265
Merged
dietmarkuehl merged 3 commits intomainfrom Apr 26, 2026
Merged
added tests for completions being called and fixed an issue with let#265dietmarkuehl merged 3 commits intomainfrom
dietmarkuehl merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a small testing sender adapter to verify that senders’ advertised completion signatures correspond to completion calls that can actually be made, and updates let’s completion signature computation to include set_error(exception_ptr) when the let function may throw.
Changes:
- Add
test::completion_testsender wrapper that converts any completion (set_value/set_error/set_stopped) into aset_value()completion for use withsync_wait. - Add new completion-signature smoke tests for
justandlet_valuepipelines. - Fix
letcompletion signatures to includeset_error_t(std::exception_ptr)when invoking the provided function is notnoexcept.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/beman/execution/include/test/completion_test.hpp |
New test helper sender/receiver used to validate that advertised completions are callable. |
tests/beman/execution/exec-let.test.cpp |
Adds a let_value completion-signature test using the new helper. |
tests/beman/execution/exec-just.test.cpp |
Adds just/just_error/just_stopped completion-signature tests using the new helper. |
include/beman/execution/detail/let.hpp |
Extends let completion-signature computation to account for potentially-throwing Fun invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.