fix: require authentication on user, tier and rate-limit read endpoints - #284
Merged
Merged
Conversation
Add CurrentUserDep to GET /users/{username}, tier list/lookup, and
rate-limit list/get endpoints, matching their documented 401 behavior.
Update the API route table accordingly.
…only, and pin the gates with tests
# Conflicts: # docs/user-guide/api/index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /users/{username} had no authentication dependency and returned UserRead including the email address, so anyone could enumerate user emails by username. The tier and rate-limit read endpoints were also public even though their docstrings describe them as available to authenticated users and document 401 responses.
This PR adds the existing current-user dependency to those endpoints, matching the behavior the docstrings already described. Docs updated; integration tests passing.
Written by Kimi, Authored by @emiliano-go