Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1501.
--checkupscanned every trimmed line of the source. A legal multilineStringbody containingimport ./missing.bend as Missingtherefore caused an independent filesystem lookup and failed an otherwise valid aggregation; import-looking text naming a real IO module could also select a module outside the import header.Follow the existing normal loader's header rule: skip blank/comment lines, and stop at the first non-import line. The aliased-import selector and independent module checking/running remain unchanged. No parser or
bend2/bend.tschanges.Added a consumer regression in
gates/ping.ts: the aggregation first passes ordinary--check-only, then its real imported sum must independently return5nwithout treating a multiline body string as an additional import. The exact assertion fails against unchanged upstream (--checkupexits 1 with ENOENT) and passes against the compiled, installed-layout CLI (--checkupexits 0 and returns5n).Verification:
bun gates/repo.ts: 54 / 54.bun build --compileand an adjacentbend2installation.5n; hidden body IO is not run.The full private-site-dependent
gates/ping.tsinstallation suite was not run here; its newly added assertion was executed directly with the real before/after CLIs.GUIDE.md,CHANGELOG.md, and protected human source were not changed.