Upgrade llama.cpp from b9549 to b9553#216
Merged
Merged
Conversation
API compatibility: the only breaking change in this range is common_sampler_types_from_names() dropping its `bool allow_alt_names` parameter (common/sampling.h). All call sites (common/arg.cpp, common/common.cpp, tools/server/server-task.cpp) are upstream-compiled translation units that upstream updated in the same patch; grep confirms zero references to the symbol in src/main/cpp / src/test/cpp, so no project C++ source change is required. New behaviour gained for free: server-task.cpp previously passed allow_alt_names=false, so the project's "samplers" JSON field only matched canonical snake_case names. b9553 always accepts aliases (top-k, topk, nucleus, temp, typ) and is case-insensitive. Added 5 params_from_json_cmpl tests in test_server.cpp pinning this. Other changes in range are no-ops for the JNI build: the llama-kv-cache shared-cells refactor (internal src/ headers not included by the project; new `using llama_kv_cells_vec`) and two Python conversion-script .get() robustness fixes. Updated GIT_TAG (CMakeLists.txt), the README badge/link, and the CLAUDE.md pinned version. cmake configure verified clean against b9553; full build + ctest verification and the breaking-changes log row to follow.
…/440 build Records the common_sampler_types_from_names signature change (and the free lenient-sampler-name behaviour), the llama-kv-cache shared-cells refactor, and the Python conversion-script fixes. Build + ctest verified clean against b9553: 440/440 tests pass (435 prior + 5 new Samplers_* tests).
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
llama.cpp b9553 Changes
The upstream release modified
common_sampler_types_from_names()to:allow_alt_namesparameter — sampler name matching is now always lenienttop-k,topk)nucleus→top_p,temp→temperature,typ→typical_p)TOP_K,Temperaturenow accepted)This project has no call sites to this function, so no source-level changes were required. However, the server's JSON
"samplers"field now accepts a broader range of input formats.Test Coverage
Added 5 new unit tests to
test_server.cppdocumenting the new behavior:Samplers_CanonicalNames_Parsed— canonical snake_case names workSamplers_KebabCaseAlias_NowAccepted— kebab-case aliases (top-k,min-p) now acceptedSamplers_CaseInsensitive— case-insensitive matching (TOP_K,Temperature,Min-P)Samplers_MiscAliases_Parsed— miscellaneous aliases (nucleus,temp,typ)Samplers_UnknownName_SkippedNotError— unknown names are warned and skippedDocumentation Updates
GIT_TAGfrom b9549 to b9553Test plan
cmake -B build && cmake --build build --config Releasepasses cleanlyRelated issues / PRs
Upstream: llama.cpp b9553
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdhttps://claude.ai/code/session_01LmHENudRrQiLao8vAPmmCB