Repository navigation
fix(ci): pass the macOS 14 job (whisper probe root, hidden AI tab) - #3
Merged
Merged
Conversation
Hosted CI's macOS 14 job has failed on main since 2026-10-08, with two causes. WhisperServerSetup.readinessProbeURL used URL.deletingLastPathComponent(). On macOS 14 Foundation that turns a root path "/" into "/../", so the readiness probe for a spawned whisper-server (http://127.0.0.1:<port>/) left the root it is bound to. That is a real bug, not only a test failure. The parent path is now computed from the percent-encoded path, so every OS gives the same answer. A new test covers the empty, root, double-slash, trailing-slash, percent-encoded and IPv6 shapes. The empty-path case fails on the old code on current macOS too ("http://127.0.0.1:8080" was returned with no path). testOpeningPreferencesFirstTimeReloadsAllExactlyOnce opened Preferences on .ai and counted the AI pane's reloads. Before macOS 26 the AI tab is hidden (PreferencesTab.visibleCases) and select(.ai) presents General, so the AI count was nil. The product behaviour is right and the test assumed the tab was visible. It now checks the tab actually presented, and on older systems also checks that the hidden AI pane is never built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted CI's macOS 14 job has failed on
mainsince 2026-10-08. This fixes both causes.Whisper readiness probe (real bug on macOS 14).
readinessProbeURLusedURL.deletingLastPathComponent(). On macOS 14 that turns/into/../, so the probe for a spawnedwhisper-serverathttp://127.0.0.1:<port>/checked/../. The parent path is now computed directly, so every OS gives the same answer.testReadinessProbeIsAnExplicitRootForEveryPathShapefails on the old code locally (empty-path case), and passes with the fix.Preferences reload test (test assumption). Before macOS 26 the AI tab is hidden, so
show(tab: .ai)presents General and the AI pane is never built. The test now checks the tab actually presented, and on older systems also checks that the hidden AI pane is not built.Local
./Scripts/test.shresults:AIPreviewRefusalPartialTests, which passed 10/10 alone.The macOS 14 result can only be confirmed by this PR's CI run.
🤖 Generated with Claude Code