Decode and preserve BOM-marked UTF-16 text files - #232
Draft
github-actions[bot] wants to merge 2 commits into
Draft
Decode and preserve BOM-marked UTF-16 text files#232github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decode BOM-marked UTF-16LE and UTF-16BE text files for editor reads and content search. Preserve the existing BOM and byte order when saving edits; keep UTF-8 behavior unchanged.
Closes #230
Type of Change
Testing
Manual Testing Details:
pnpm --filter @hubble.md/desktop exec vitest run electron/textFile.test.ts— 3 tests passedpnpm --filter @hubble.md/desktop test— 185 tests passedpnpm build:desktop— passedpnpm exec biome check apps/desktop/electron/textFile.ts apps/desktop/electron/textFile.test.ts apps/desktop/electron/main.ts— passedHUBBLE_DESKTOP_ENABLE_CDP=1 pnpm dev:desktop, but Electron could not launch because the container's SUID sandbox helper is not configured with root ownership and mode 4755.Checklist
Implemented by a Warp Factory agent.