feat: keep sidebar folders alphabetized across file sort modes - #258
Open
n00ki wants to merge 1 commit into
Open
feat: keep sidebar folders alphabetized across file sort modes#258n00ki wants to merge 1 commit into
n00ki wants to merge 1 commit into
Conversation
|
@n00ki is attempting to deploy a commit to the bholmesdev's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Overview
Keeps sidebar folders A–Z (natural sort) at every depth while Recent/Name apply only to files, including pinned. Drops unused folder modifiedAt plumbing, tightens sort control a11y copy, and adds focused tree-sort tests.
Concerns
None material. Natural numeric/case-insensitive name compare is an intentional alpha-mode behavior change and is covered by tests.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Reviewed by a Warp Factory agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Sorting by
Recentis useful for finding active files, but it also reordered folders and disrupted intentionally organized workspace structures such as00 Inboxand02 Notes.This change separates those concerns: folders remain a stable, alphabetical navigation structure, while files continue to follow the selected
RecentorNameorder. It keeps Hubble’s streamlined sorting controls while makingRecentmore practical for structured workspaces.Alternatives considered
I explored adding ascending and descending directions to both
Recent- based on modification time, andName. While useful in some editors, four sorting choices added complexity without addressing the primary issue: selectingRecentdisrupted intentionally organized folder structures.I therefore kept Hubble’s existing
Recent/Namemodel and separated folder ordering from file ordering. Sorting directions can still be considered independently in the future.Summary
RecentandNameoptions.Testing
pnpm checkpnpm check:react-compilerpnpm build:desktop