Skip to content

Fix audit-discovered robustness and localization gaps - #190

Merged
bifrost0x merged 2 commits into
mainfrom
dev/fix-project-audit-findings
Sep 2, 2026
Merged

Fix audit-discovered robustness and localization gaps#190
bifrost0x merged 2 commits into
mainfrom
dev/fix-project-audit-findings

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • keep disconnect cleanup running through database lookup, commit, and rollback failures by falling back to the single-worker socket registry
  • reject non-object JSON and malformed field types across admin, LDAP, OIDC, backup, audit-retention, and GitHub step-up mutations
  • make stored language and terminal scrollback preferences safe when browser storage is blocked, stale, or malformed
  • add the missing command-set translations to all six locales and validate translation references across every first-party JavaScript module
  • bump affected frontend asset versions so the fixes are delivered without stale browser caches

Validation

  • combined Python suite: 2333 passed, 2 skipped
  • JavaScript unit suite: 36 passed
  • Playwright: 102 passed across two shards
  • ESLint: passed
  • vendored frontend assets: 10 verified
  • Docker Compose configuration: passed
  • Python compilation, shell syntax, and git diff checks: passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T18:57:13.590685Z d059ce4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d059ce4934

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/socket_events.py
Comment thread static/js/command-set-manager.js
@bifrost0x
bifrost0x merged commit 615ede3 into main Sep 2, 2026
21 checks passed
@bifrost0x
bifrost0x deleted the dev/fix-project-audit-findings branch September 2, 2026 19:19
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Sep 2, 2026
@bifrost0x bifrost0x self-assigned this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant