Skip to content

Fix terminal selection copying - #194

Merged
bifrost0x merged 1 commit into
mainfrom
dev/fix-terminal-copy-selection
Sep 3, 2026
Merged

Fix terminal selection copying#194
bifrost0x merged 1 commit into
mainfrom
dev/fix-terminal-copy-selection

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • copy xterm selections directly through the Clipboard API for Ctrl+C and Cmd+C while preserving Ctrl+C as terminal interrupt input when nothing is selected
  • route the Command Palette copy and paste actions through real functions instead of missing DOM buttons
  • add unit and browser regression coverage for keyboard and palette copying

Testing

  • NODE_PATH=/home/heimdall/Dokumente/ChatGPT/webssh/node_modules node --test tests/js/*.test.js
  • eslint static/js/app.js static/js/terminal-manager.js tests/e2e/session-workspace.spec.js tests/js/terminal-manager-layout.test.js
  • python -m pytest -q (2,348 passed and 29 skipped in the sandbox; the four socket-bound tests were rerun outside the socket sandbox and passed)
  • playwright test tests/e2e/session-workspace.spec.js tests/e2e/profile-launcher.spec.js --forbid-only (35 passed)

Closes #193

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T07:47:41.602955Z c1b70ac PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bifrost0x
bifrost0x merged commit 1fc5176 into main Sep 3, 2026
21 checks passed
@bifrost0x
bifrost0x deleted the dev/fix-terminal-copy-selection branch September 3, 2026 09:56
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

1 participant